Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Should not (evil-set-jump previous-pos) jump after evil-jump-forward #1772

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

roxma
Copy link
Contributor

@roxma roxma commented Mar 26, 2023

Steps to reproduce the issue:

  • Create files a b c with the following content:
        $ head a b c
        ==> a <==
        b
    
        I'm A
        ==> b <==
        c
    
        I'm B
        ==> c <==
        I'm C
  • Run emancs a to open bufer a
  • Press gf to jump to bufer b
  • Press gf to jump to bufer c
  • Press C-o to jump back to bufer b
  • Press C-o to jump back to bufer a
  • Press C-i to jump foward to bufer b
  • Press C-i to jump foward to bufer c, but the window stays on buffer b unexpectedly.

@roxma
Copy link
Contributor Author

roxma commented Jun 9, 2023

@tomdl89 @axelf4
Hi, could you please comment on this pull request?

evil-jumps.el Show resolved Hide resolved
@tomdl89
Copy link
Member

tomdl89 commented Jun 10, 2023

@roxma thanks for the PR. As mentioned in the comment, I don't think you need to revert the renaming.
Can you add tests for this? I've noticed there are tests in the deftest evil-test-jump, namely in the ert-info Jump across files, which you may be able to add to. Could you take a look? Thanks.

@dschrempf
Copy link

Has there been any progress? I also have this problem. Whenever I jump back repeatedly, I can only jump forwards once.

…ward

Steps to reproduce the issue:

  - Create files `a` `b` `c` with the following content:

    $ head a b c
    ==> a <==
    b

    I'm A
    ==> b <==
    c

    I'm B
    ==> c <==
    I'm C

  - Run `emancs a` to open bufer `a`
  - Press `gf` to jump to bufer `b`
  - Press `gf` to jump to bufer `c`
  - Press `C-o` to jump back to bufer `b`
  - Press `C-o` to jump back to bufer `a`
  - Press `C-i` to jump foward to bufer `b`
  - Press `C-i` to jump foward to bufer `c`, but the window stays with
    buffer unexpectedly.
@tomdl89 tomdl89 force-pushed the 2303-multi-jump-forward branch 3 times, most recently from 557d115 to d5d5152 Compare July 12, 2024 22:16
@tomdl89 tomdl89 force-pushed the 2303-multi-jump-forward branch from d5d5152 to e3530b9 Compare July 12, 2024 22:37
@tomdl89 tomdl89 merged commit fc99343 into emacs-evil:master Jul 12, 2024
12 checks passed
@tomdl89
Copy link
Member

tomdl89 commented Jul 12, 2024

@dschrempf apologies for the delay. Now fixed in master. Please let me know if you observe otherwise.

@dschrempf
Copy link

Wow, that was fast, thanks a lot!

@roxma
Copy link
Contributor Author

roxma commented Jul 23, 2024

@tomdl89 Thank you for adding the tests.

@dschrempf
Copy link

I can also confirm that this is working! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants